Skip to content

document configuring plugins on client #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2016
Merged

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Aug 12, 2016

@@ -165,7 +165,10 @@ The bundle has client factory services that you can use to build your client. If
Plugins
```````

You can configure the clients with plugins. You can choose to use a built in plugin in the ``php-http/plugins`` package or provide a plugin of your own. The order of the specified plugin does matter.
Clients can have plugins. Generic plugins from ``php-http/plugins`` (e.g. retry or redirect) can be configured globally. You can tell the client which of those plugins to use, as well as custom plugins that you configured a service for.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/as custom/as custom/ (double space)

@Nyholm
Copy link
Member

Nyholm commented Aug 12, 2016

Good work!

@dbu dbu force-pushed the symfony-bundle-client-plugins branch from babacf0 to cfc9ee2 Compare August 12, 2016 14:21
@Nyholm
Copy link
Member

Nyholm commented Aug 13, 2016

👍

@dbu dbu changed the title document configuring plugins on client [WCM] document configuring plugins on client Aug 15, 2016
@dbu dbu force-pushed the symfony-bundle-client-plugins branch from cfc9ee2 to 87d2d80 Compare August 15, 2016 08:34
@dbu dbu changed the title [WCM] document configuring plugins on client document configuring plugins on client Aug 15, 2016
@dbu
Copy link
Contributor Author

dbu commented Aug 15, 2016

code is merged. final review?

@Nyholm Nyholm merged commit a38beef into master Aug 15, 2016
@Nyholm Nyholm deleted the symfony-bundle-client-plugins branch August 15, 2016 08:38
@Nyholm
Copy link
Member

Nyholm commented Aug 15, 2016

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants