http client factory should allow to specify additional plugins #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $user Username | ||
| * @param string $pass Password | ||
| * @param HttpClient $client Base HTTP client | ||
| * @param string $user Username |
There was a problem hiding this comment.
Do we need this username comment thing?
There was a problem hiding this comment.
tried making it more verbose to make it more useful
| * | ||
| * @return HttpClient | ||
| */ | ||
| public static function create($user, $pass, HttpClient $client = null) | ||
| public static function create($user, $pass, $plugins = [], HttpClient $client = null) |
There was a problem hiding this comment.
Is there an array typehint here?
There was a problem hiding this comment.
fixed. seems the new github interface does not automatically hide comments that are obsolete anymore
There was a problem hiding this comment.
Maybe it doesn't like force push?
dbu
force-pushed
the
allow-custom-plugins
branch
from
803eb75 to
bb625ae
Compare
sagikazarmark
approved these changes
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.