Mention Slim Framework factories #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
👍 php-http/message#53 requires slim 3.5 at least. should we mention somewhere in the doc that the code is not compatible with older versions of slim? or is there no reason for the factories to go with slim 3.5 and it could be ^3.0? then the lowest tests would ensure it works with slim 3.0 and the other tests would still look at the newest released 3.x version of slim. |
|
There should be no problems with 3.0 but I will test it first. |
|
and that concludes the feature. thanks a lot for your contribution @tuupola ! |
|
Glad I can help. This project is awesome! Just finished writing an SDK to an internal API we are using. Can not believe how easy it was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accompanying documentation PR for php-http/message#53 if it gets approved. Running
make htmlbuilds docs successfully.