cleanup documentation pages #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
doc-style-cleanup
branch
from
4c79c69 to
20b0de7
Compare
Nyholm
reviewed
Oct 18, 2016
| 3. Plugins which log information should be last (like Logger or History Plugin) | ||
| 1. Plugins that modify the request should be at the beginning (like Authentication or Cookie Plugin); | ||
| 2. Plugins which intervene in the workflow should be in the "middle" (like Retry or Redirect Plugin); | ||
| 3. Plugins which log information should be last (like Logger or History Plugin). |
There was a problem hiding this comment.
I've never seen semi colons at the end of a list like this.
I suggest removing them and also the period.
There was a problem hiding this comment.
this is the symfony doc style afaik. i can't find it mentioned explicitly on http://symfony.com/doc/current/contributing/documentation/standards.html#code-examples but at least that example also has them.
but i am fine with removing them again if others also don't like them. i got used to them, so i'd vote to keep doing them, but its no big deal for me.
There was a problem hiding this comment.
Okey, I just have not noticed that.
Let's keep them.
|
I'm 👍 Ready for merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make style more consistent and improve some wordings