Skip to content

Add missing configuration key #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Add missing configuration key #184

merged 1 commit into from
Mar 16, 2017

Conversation

greg0ire
Copy link
Contributor

The code and the error messages say it should be like this.

The code and the error messages say it should be like this.
@Nyholm
Copy link
Member

Nyholm commented Mar 14, 2017

Are you sure about this?

@greg0ire
Copy link
Contributor Author

I could be mistaken, I'm not configuring the bundle directly. But what do you think about this : https://github.com/php-http/HttplugBundle/blob/master/DependencyInjection/Configuration.php#L308 ? I can agree that this key looks a bit useless though.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the configuration indeed seems to request this format.

i think the key is useful, if we ever would add anything else than the list of headers, we would need a BC break if we don't wrap the list under its own key.

@greg0ire
Copy link
Contributor Author

@dbu makes sense

@dbu dbu merged commit d47ed02 into php-http:master Mar 16, 2017
@greg0ire greg0ire deleted the patch-1 branch March 16, 2017 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants