-
Notifications
You must be signed in to change notification settings - Fork 56
Add content-type plugin documentation #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content-type plugin documentation #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
plugins/content-type.rst
Outdated
@@ -0,0 +1,18 @@ | |||
Content-Type Plugin | |||
===================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove 2 "=".
plugins/content-type.rst
Outdated
[$contentTypePlugin] | ||
); | ||
|
||
For now, the plugin could only detect Json or XML content. If the content of the stream can not be determined, the plugin does nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write "JSON" instead.
plugins/content-type.rst
Outdated
[$contentTypePlugin] | ||
); | ||
|
||
For now, the plugin could only detect Json or XML content. If the content of the stream can not be determined, the plugin does nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/could/can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
I will merge this as soon as the implementation is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thing
plugins/content-type.rst
Outdated
When set to ``true``, content type detection will be performed only if the body request content size is under the | ||
size_limit parameter value. | ||
|
||
``size_limit``: int (default: 16 Mb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(default: a little bit over 15Mb)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16000000/1024/1024 = 15,258789063
Thank you |
No description provided.