Skip to content

Add content-type plugin documentation #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2017

Conversation

kpn13
Copy link
Contributor

@kpn13 kpn13 commented Jul 10, 2017

No description provided.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

@@ -0,0 +1,18 @@
Content-Type Plugin
=====================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 2 "=".

[$contentTypePlugin]
);

For now, the plugin could only detect Json or XML content. If the content of the stream can not be determined, the plugin does nothing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write "JSON" instead.

[$contentTypePlugin]
);

For now, the plugin could only detect Json or XML content. If the content of the stream can not be determined, the plugin does nothing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/could/can

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nyholm
Copy link
Member

Nyholm commented Jul 21, 2017

I will merge this as soon as the implementation is merged.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing

When set to ``true``, content type detection will be performed only if the body request content size is under the
size_limit parameter value.

``size_limit``: int (default: 16 Mb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(default: a little bit over 15Mb)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16000000/1024/1024 = 15,258789063

@Nyholm
Copy link
Member

Nyholm commented Aug 10, 2017

Thank you

@Nyholm Nyholm merged commit 44b726d into php-http:master Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants