Skip to content

Added docs about what packages we accept to be listed #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2017
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 13, 2017

No description provided.

@Nyholm Nyholm requested a review from dbu July 13, 2017 12:05
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, just some nitpicks on wording.

README.md Outdated
#### Add your package under "They use us"

We want to keep this list of packages to a small number. If your package should be considered for be listed here
it must be a well known packages with about a million downloads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...with a significant number of downloads (a million or more)."

README.md Outdated
it must be a well known packages with about a million downloads.

However, we are much less strict with the packages on [httplug.io](http://httplug.io/). On [that repository](https://github.com/php-http/httplug.github.io)
we generally accept any well written package with a few hunreds downloads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/hunreds/hundreds

but i think i would not put numbers here. rather say something like "any stable and documented package using httplug."

@Nyholm
Copy link
Member Author

Nyholm commented Jul 13, 2017

Thank you for your suggestions

@Nyholm Nyholm merged commit e777223 into master Aug 4, 2017
@dbu dbu deleted the Nyholm-patch-2 branch July 23, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants