Skip to content

Documentation for cURL client. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2016
Merged

Documentation for cURL client. #81

merged 4 commits into from
Jan 27, 2016

Conversation

mekras
Copy link
Contributor

@mekras mekras commented Jan 26, 2016

No description provided.

$client = new Client($messageFactory, $streamFactory);


Using `mekras/httplug-diactoros-bridge <https://packagist.org/packages/mekras/httplug-diactoros-bridge>`_::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message factories are moved to php-http/message package. Doesn't it fulfill your requirements?

@mekras
Copy link
Contributor Author

mekras commented Jan 27, 2016

Updated

-----

The cURL client needs a :ref:`message <message-factory>` and a :ref:`stream <message-factory>`
factories in order to to work::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/factories/factory

@mekras
Copy link
Contributor Author

mekras commented Jan 27, 2016

Updated.

];
$client = new Client(MessageFactoryDiscovery::find(), StreamFactoryDiscovery::find(), $options);

These options can not be used:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding an explanation here would make sense, why these options can't be used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/can not/cannot

@mekras
Copy link
Contributor Author

mekras commented Jan 27, 2016

Updated.

@sagikazarmark
Copy link
Member

LGTM, thanks @mekras

sagikazarmark added a commit that referenced this pull request Jan 27, 2016
Documentation for cURL client.
@sagikazarmark sagikazarmark merged commit 9f87c4c into php-http:master Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants