Create the React adapter documentation #83
Conversation
|
|
||
| $client = new Client($messageFactory); | ||
|
|
||
| For simplicity, all the required objects are built internally by default: |
There was a problem hiding this comment.
s/built internally by default/instantiated automatically if not explicitly specified/ ?
shulard
force-pushed
the
feature/react-adapter-doc
branch
from
af2fd53 to
dd68757
Compare
| ------------ | ||
|
|
||
| To install the React adapter, which will also install React itself (if it was | ||
| not yet included in your project), run: |
There was a problem hiding this comment.
WDTY of : "Use composer to install the React adapter. It will also install React as it's a dependency."
shulard
force-pushed
the
feature/react-adapter-doc
branch
from
dd68757 to
2d4e0c4
Compare
|
What's the situation with this one. |
|
I've reviewed all the feedbacks and updated the files... If this page is complete, it can be merged ! |
|
@shulard it looks like you did not push your fixes. can you please check and push them? apart from that i think its ready for merging. |
shulard
force-pushed
the
feature/react-adapter-doc
branch
from
2d4e0c4 to
b8582e1
Compare
|
@dbu, indeed I haven't added the changes before commit... It's now really pushed! Sorry for that mistake 😄. |
|
Can you add installation instructions for message factory and discovery? https://github.com/php-http/documentation/pull/84/files#diff-79875bdeec6865600aca86d31fe5f2d9R16 |
|
LGTM |
shulard
force-pushed
the
feature/react-adapter-doc
branch
2 times, most recently
from
0d0f9aa to
e92b9b4
Compare
|
I've added the instructions for message factory and discovery. |
| Installation | ||
| ------------ | ||
|
|
||
| Use composer to install the React adapter. It will also install React as it's a |
There was a problem hiding this comment.
please write as "Composer_" to have this link to composer. (without the quotes). the link target is defined in the conf.py file in the root folder, as we use it all over the place
|
looks good to me, maybe link "composer" as i proposed. |
shulard
force-pushed
the
feature/react-adapter-doc
branch
from
e92b9b4 to
c610d5f
Compare
|
I've added the link to Composer. |
Create the React adapter documentation
|
cheers! |
Hello !
I've created the documentation page for the React adapter lib.