Guzzle 5 #84
Merged
Guzzle 5 #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddeboer can you help me with the failing tests? |
|
|
||
| In order to provide full interoperability, message implementations are | ||
| accessed through :ref:`factories <message-factory>`. Message factories for | ||
| `Diactoros`_ are `Guzzle PSR-7`_ implementations are available in the |
There was a problem hiding this comment.
you mean remove PSR-7?
|
@joelwurtz @dbu good catch, thanks. Now I have another problem related to |
|
|
||
| $adapter = new GuzzleAdapter($guzzle, new GuzzleMessageFactory()); | ||
|
|
||
| Or if you installed the :ref:`discovery <discovery>` layer:: |
There was a problem hiding this comment.
did you define a label discovery somewhere? if you want to link to the document discovery.rst, its :doc:. :ref: is for linking to labels within some page (anchor links in the same or another page).
There was a problem hiding this comment.
No, I thought I can just link to a page with the same name 😄
sagikazarmark
force-pushed
the
guzzle5
branch
from
e5c1645 to
0636004
Compare
Fix indentation Fix cross-linking Fix cross-linking Fix cross-linking
sagikazarmark
added a commit
that referenced
this pull request
Feb 1, 2016
Add Guzzle 5 documentation
shulard
pushed a commit
to shulard/documentation
that referenced
this pull request
Feb 18, 2016
Add Guzzle 5 documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joelwurtz I changed Socket client docs as well.