This repository was archived by the owner on Jan 6, 2024. It is now read-only.
improve promise exception #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
| @@ -63,7 +63,7 @@ public function __construct(PromiseInterface $promise, RequestInterface $request | |||
| } | |||
|
|
|||
| if (!($reason instanceof GuzzleExceptions\GuzzleException)) { | |||
| throw new \RuntimeException("Invalid reason"); | |||
| throw new \RuntimeException("Invalid exception returned from Guzzle6", $reason); | |||
There was a problem hiding this comment.
it is not throw new \RuntimeException("Invalid exception returned from Guzzle6", 0, $reason); ?
And what if the reason is not an exception at all (like a string or other thing) ?
There was a problem hiding this comment.
ups, good point. i will add a type check there. if its not an exception, i will keep ignoring it, we don't consider returning a string as reason a good idea.
There was a problem hiding this comment.
Actually I think it is a UnexpectedValue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the exception stays, we really should keep the nested exception or this will be very annoying to debug.