Allow PHP 8.0 #15
Merged
Allow PHP 8.0 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
thanks
we seem to already test with php 8 but use the ignore-platform-req=php flag https://github.com/php-http/logger-plugin/blob/master/.github/workflows/tests.yml#L33
i will merge and tag a version, but it is possible the plugin is not actually installable because some dependencies might not allow php 8 yet.
|
Checked the child dependencies. They are 80 compatible. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR allows to require the package on PHP 8. Luckily all hard work was already done :)