-
Notifications
You must be signed in to change notification settings - Fork 7
Adding time for the request #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sounds valuable to me, lets do it! |
I found this PR which I did not complete. Im not sure how I could make PHPSpec allow me to add a random integer like I did. I've searched the manual extensively but found nothing. |
@Nyholm This is how you would handle it: nicholasruunu@b708f38 But the "Received response" info calls are actually not being made when you call |
Awesome Nicholas. Thank you. Will finish this PR tonight. |
The test showed that my implementation was flawed. Thanks again for helping me. I've used your commit and I've updated the PR. Im now ready for a review |
Nice one. i'm also wondering if we should use |
Thank you for the review. Hm.. Isn't that done already if you use the Symfony Bundle? |
It was more using Stopwatch implementation instead of microtime if available, but not really necessary |
What's in this PR?
We should log the time it takes to make a request
If we think this is something we want Im happy to complete this PR.
To Do