Skip to content

Support both client-common ^1.9 and 2.x #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 29, 2018
Merged

Support both client-common ^1.9 and 2.x #9

merged 6 commits into from
Dec 29, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 28, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

This will replace #8

Blocked by php-http/client-common#132

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Nyholm
Copy link
Member Author

Nyholm commented Dec 29, 2018

Thank you for the reviews!

@Nyholm Nyholm merged commit 7736e42 into master Dec 29, 2018
@Nyholm Nyholm deleted the patch-common1.9 branch December 29, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants