Add new RequestMatch authentication method #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @author Márk Sági-Kazár <[email protected]> | ||
| */ | ||
| final class RequestMatch implements Authentication |
There was a problem hiding this comment.
maybe we could call this ConditionalAuthentication?
There was a problem hiding this comment.
We should somehow have the request in the name...otherwise what condition would it be?
There was a problem hiding this comment.
I fear we can't find a self-explanatory name enough, we have to document it anyway.
There was a problem hiding this comment.
i would like RequestConditional better. and explain it - the phpdoc above looks fine to me.
sagikazarmark
force-pushed
the
match_auth
branch
from
ec83dc0 to
0f422df
Compare
|
Yeah, I replaced the matching auth with the request matcher interface one. It indeed relied on that PR, as the deprecated matcher now uses the callback request matcher internally. |
sagikazarmark
force-pushed
the
match_auth
branch
2 times, most recently
from
7ab3a93 to
9239314
Compare
sagikazarmark
force-pushed
the
match_auth
branch
from
9239314 to
f7d3a21
Compare
sagikazarmark
added a commit
that referenced
this pull request
Mar 4, 2016
Add new RequestMatch authentication method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sagikazarmark found this branch lying around. it seems to add on #34 - is it relevant?