-
Notifications
You must be signed in to change notification settings - Fork 11
Added custom mimetype helper #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
<?php | ||
|
||
namespace Http\Message\MultipartStream; | ||
|
||
/** | ||
* Let you add your own mimetypes. The mimetype lookup will fallback on the ApacheMimeTypeHelper. | ||
* | ||
* @author Tobias Nyholm <[email protected]> | ||
*/ | ||
class CustomMimetypeHelper extends ApacheMimetypeHelper | ||
{ | ||
/** | ||
* @var array | ||
*/ | ||
private $mimetypes = []; | ||
|
||
/** | ||
* @param array $mimetypes should be of type extension => mimetype | ||
*/ | ||
public function __construct(array $mimetypes = []) | ||
{ | ||
$this->mimetypes = $mimetypes; | ||
} | ||
|
||
/** | ||
* @param string $extension | ||
* @param string $mimetype | ||
* | ||
* @return $this | ||
*/ | ||
public function addMimetype($extension, $mimetype) | ||
{ | ||
$this->mimetypes[$extension] = $mimetype; | ||
|
||
return $this; | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
* | ||
* Check if we have any defined mimetypes and of not fallback to ApacheMimetypeHelper | ||
*/ | ||
public function getMimetypeFromExtension($extension) | ||
{ | ||
$extension = strtolower($extension); | ||
|
||
return isset($this->mimetypes[$extension]) | ||
? $this->mimetypes[$extension] | ||
: parent::getMimetypeFromExtension($extension); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<?php | ||
|
||
namespace tests\Http\Message\MultipartStream; | ||
|
||
use Http\Message\MultipartStream\CustomMimetypeHelper; | ||
|
||
class CustomMimetypeHelperTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testGetMimetypeFromExtension() | ||
{ | ||
$helper = new CustomMimetypeHelper(['foo'=>'foo/bar']); | ||
$this->assertEquals('foo/bar', $helper->getMimetypeFromExtension('foo')); | ||
|
||
$this->assertEquals('application/x-rar-compressed', $helper->getMimetypeFromExtension('rar')); | ||
$helper->addMimetype('rar', 'test/test'); | ||
$this->assertEquals('test/test', $helper->getMimetypeFromExtension('rar')); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not sure we need an adder for this. the constructor should be enough, its not like we discover mime types at runtime - or is there a use case for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure this would ever be used, no. But I thought "why not?" This class should only be used in the 1% edge case. And if you are such end case you are probably doing something special and could probably be in a scenario when you want to edit this at runtime.