change basename to pathinfo

[GreenSuslik]

Detail #16

[Nyholm]

Thank you for this!

[sagikazarmark]

Looks ok to me: https://3v4l.org/9gkFR

Might worth bringig up the issue here as well: https://github.com/webmozart/path-util/blob/master/src/Path.php#L330

It's a nice path utility package.

[Nyholm]

Thank you.

webmozart/path-util#22

[sagikazarmark]

Actually: would it make sense to add some tests with special characters?

[Nyholm]

I was wrong merging this. pathinfo is also locale aware. Im trying to find a solution.

[GreenSuslik]

@Nyholm in offical php doc only basename have locale aware caution, pathinfo not have it

[Nyholm]

It does.. http://php.net/manual/en/function.pathinfo.php#refsect1-function.pathinfo-notes

[GreenSuslik]

OMG on basename page it is big colored block on top, on pathinfo is similar small small text on bottom page. It's very bad. Pathinfo work with russian file name, but basename not work, it add invalid char to start

[Nyholm]

Im editing the wiki now.