Skip to content

Add support for PSR17 factories #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 22, 2019
Merged

Add support for PSR17 factories #38

merged 9 commits into from
Aug 22, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Aug 22, 2019

No description provided.

@Nyholm
Copy link
Member Author

Nyholm commented Aug 22, 2019

I decided to bump PHP version requirement because they are super dead and travis wouldn't run on them.. like "This PHP version is not supported".

dbu
dbu approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

would supporting php 7.1 be an issue? if it does not cost us much effort, i'd prefer to keep allowing it, for people stuck on older infrastructure.

@Nyholm
Copy link
Member Author

Nyholm commented Aug 22, 2019

Sure!

Thank you for the review

@Nyholm Nyholm merged commit 67c0c52 into master Aug 22, 2019
@dbu dbu deleted the psr17 branch August 22, 2019 14:09
dbu
dbu reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @dbu