Skip to content

Add pkpass (Apple Passbook) to list of Mime-Types #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2016

Conversation

airlst
Copy link

@airlst airlst commented Aug 10, 2016

.pkpass is the official extension from apple for passbook (apple wallet).

Documentation:
https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/PassKit_PG/DistributingPasses.html

@dbu
Copy link
Contributor

dbu commented Aug 10, 2016

i guess we can merge this.

but in general, we should have a way to add custom mime types in this class. there will be more obscure formats than apple, and we don't want to make this a comprehensive list of all file formats ever existing (and would run into collisions sooner or later, too)

@airlst
Copy link
Author

airlst commented Aug 10, 2016

Hi @dbu,

certainly a good point.

We're using php-http as a dependency from the official mailgun php sdk to send emails, so this change would at least benefit this project and a larger community.

Best
Philipp

@Nyholm Nyholm merged commit 8105691 into php-http:master Aug 10, 2016
@dbu
Copy link
Contributor

dbu commented Aug 10, 2016

sorry for hijacking this ticket. created #10 for the topic of custom mime types.

@Nyholm
Copy link
Member

Nyholm commented Aug 10, 2016

FYI @airlst, I've tagged 0.1.1

@airlst
Copy link
Author

airlst commented Aug 10, 2016

@Nyholm thanks for tagging, awesome response time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants