Add request conditional plugin #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
force-pushed
the
conditional_plugin
branch
from
bd39a68 to
8035119
Compare
Applied fixes from StyleCI
sagikazarmark
force-pushed
the
conditional_plugin
branch
from
8035119 to
53fd56d
Compare
| * @param RequestMatcher $requestMatcher | ||
| * @param Plugin $delegatedPlugin | ||
| */ | ||
| public function __construct(RequestMatcher $requestMatcher, Plugin $delegatedPlugin) |
There was a problem hiding this comment.
I maybe want to use more than one plugin. I suggest allowing the second parameter to be an array of Plugins. Would that be possible?
There was a problem hiding this comment.
I was also thinking about that. For that case I would add a separate
ChainPlugin.
Tobias Nyholm [email protected] ezt írta (2016. március 5.,
szombat):
In src/RequestConditionalPlugin.php
#65 (comment):+{
- /**
\* @var RequestMatcher*/- private $requestMatcher;
- /**
\* @var Plugin*/- private $delegatedPlugin;
- /**
\* @param RequestMatcher $requestMatcher\* @param Plugin $delegatedPlugin*/- public function __construct(RequestMatcher $requestMatcher, Plugin $delegatedPlugin)
I maybe want to use more than one plugin. I suggest allowing the second
parameter to be an array of Plugins. Would that be possible?—
Reply to this email directly or view it on GitHub
https://github.com/php-http/plugins/pull/65/files#r55119904.
|
Anyone review? |
| use Psr\Http\Message\RequestInterface; | ||
|
|
||
| /** | ||
| * Apply a delegated plugin based on a request match. |
There was a problem hiding this comment.
Execute a plugin only if the RequestMatcher matches the request.
|
would this now need to go against client-commons, now that we move the plugins there? |
|
Yes, it should. Wanted to finish it before closing and moving to common. |
sagikazarmark
added a commit
to php-http/client-common
that referenced
this pull request
Apr 3, 2016
sagikazarmark
added a commit
to php-http/client-common
that referenced
this pull request
May 1, 2016
Update todo Remove options resolver dependency Revert: Remove options resolver dependency Add AddHostPlugin Add Authentication plugins Add content length plugin Add final warning to plugins Add cookie plugin Add decoder plugin Add error plugin Add header plugins Add history plugin Fix namespace import order Add redirect plugin Add retry plugin Make plugin classes final, related #18 Fix throw keyword Manually apply php-http/plugins#68 Manually apply and close php-http/plugins#65
sagikazarmark
added a commit
to php-http/client-common
that referenced
this pull request
May 1, 2016
Update todo Remove options resolver dependency Revert: Remove options resolver dependency Add AddHostPlugin Add Authentication plugins Add content length plugin Add final warning to plugins Add cookie plugin Add decoder plugin Add error plugin Add header plugins Add history plugin Fix namespace import order Add redirect plugin Add retry plugin Make plugin classes final, related #18 Fix throw keyword Manually apply php-http/plugins#68 Manually apply and close php-http/plugins#65
sagikazarmark
added a commit
to php-http/client-common
that referenced
this pull request
May 1, 2016
Update todo Remove options resolver dependency Revert: Remove options resolver dependency Add AddHostPlugin Add Authentication plugins Add content length plugin Add final warning to plugins Add cookie plugin Add decoder plugin Add error plugin Add header plugins Add history plugin Fix namespace import order Add redirect plugin Add retry plugin Make plugin classes final, related #18 Fix throw keyword Manually apply php-http/plugins#68 Manually apply and close php-http/plugins#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: cache certain responses based on a request condition.