-
Notifications
You must be signed in to change notification settings - Fork 17
feat: implement Bedrock and model clients for Claude, Llama, and Nova #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is some code duplication in Anthropic and Bedrock. For the sake of keeping this PR small I left it in. Please be also aware that I enabled Claude Modle image support to support. This was needed to use the same model definition for using Bedrock Claude with images. I tested the image implementation for Platform Anthropic with Sonnet 3.7. |
Fixes #307 |
First of all thanks for working on this - I think it's a great addition and a very valid case in challenging the current extension points of the Platform layer - good timing for that large refactoring in #316 - but i guess we should get this merged before the other one. also the redundancy can be tackled as a follow up - that's currently a matter how the response structured is handled. please have a look at the phpstan failure, but nevermind the commit message check - just a reminder for me while merging. i will give it a detailed look right away - thanks again! 👍 |
Don't have access to the models on AWS atm, but will trust on your tests here - can you please add some examples though? |
Found the issue, I was just looking at my state not the merge result 🙈 |
@chr-hertel I fixed the ci issues and added some examples. |
needs a rebase, but other than that i'd like to merge this - thanks already! :) |
@chr-hertel Rebased and resolved conflicts in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you work @bjalt - will continue to get rid off redundencies 👍
Documentation for configurationshould be part of the bundle