Skip to content

PHPCS: various improvements #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2021

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Mar 28, 2021

  • Composer: update the PHPCS version used to PHPCS 3.5.0+.
  • PHPCS: add a PHPCS configuration file containing all the common command-line parameters.
    This file will be automatically picked up by PHPCS and can be overruled locally by a [.]phpcs.xml file.
  • Ant: remove the configuration CLI arguments which are now contained in the phpcs.xml.dist file from the build.xml task configuration.
  • Ant: add a CLI argument which will ignore CS warnings when determining the exit code, but will still show warnings in the report.
    Using this will also allow for enabling failonerror for the build step.
  • Git: Add the phpcs.xml.dist file to the .gitattributes file to be ignored when packaging a release.
  • Git: Add the potential local overload files to the .gitignore file.

* Composer: update the PHPCS version used to PHPCS 3.5.0+.
* PHPCS: add a PHPCS configuration file containing all the common command-line parameters.
    This file will be automatically picked up by PHPCS and can be overruled locally by a `[.]phpcs.xml` file.
* Ant: remove the configuration CLI arguments which are now contained in the `phpcs.xml.dist` file from the `build.xml` task configuration.
* Ant: add a CLI argument which will ignore CS warnings when determining the exit code, but will still _show_ warnings in the report.
    Using this will also allow for enabling `failonerror` for the build step.
* Git: Add the `phpcs.xml.dist` file to the `.gitattributes` file to be ignored when packaging a release.
* Git: Add the potential local overload files to the `.gitignore` file.
@jrfnl jrfnl mentioned this pull request Mar 28, 2021
@grogy grogy merged commit 9afe892 into php-parallel-lint:master May 8, 2021
@jrfnl jrfnl deleted the feature/phpcs-various-tweaks branch May 8, 2021 05:31
@jrfnl jrfnl modified the milestones: 1.x Next Release, 1.0.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants