Improve tests #24
Merged
Improve tests #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as PHPUnit < 5.7.21 doesn't contain the forward compatibility layer with namespaced classes.
* Add more detailed basic test configuration * Unless `junit` is used somewhere, generating this report for code coverage is unnecessary. * Generating the text report, however, is useful.
These methods cannot be tested as the result is system dependent and cannot be emulated.
... to document what each test is testing.
jrfnl
force-pushed
the
feature/improve-tests
branch
from
f7b8ffa to
fdddebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes together stabilize the test suite and bring the code coverage to 100% (line/branch).
Commit details
Composer: improve PHPUnit version constraints
... as PHPUnit < 5.7.21 doesn't contain the forward compatibility layer with namespaced classes.
PHPUnit: improve configuration
junitis used somewhere, generating this report for code coverage is unnecessary.ConsoleColor: mark two methods as untestable
These methods cannot be tested as the result is system dependent and cannot be emulated.
ConsoleColor::addTheme(): add test for exception
ConsoleColor::getThemes(): add perfunctory unit test
Tests: add @Covers tag
... to document what each test is testing.