Skip to content

[laravel] uses \Illuminate\Contracts\Session\Session instead of Symfony\Component\HttpFoundation\Session\SessionInterface #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

cmizzi
Copy link
Contributor

@cmizzi cmizzi commented Jan 26, 2018

To handle support for Laravel 5.[0-4], we should use Illuminate\Contracts\Session\Session instead of Symfony\Component\HttpFoundation\Session\SessionInterface

@andig
Copy link
Contributor

andig commented Jan 26, 2018

Does this include earlier Laravel version, i.e. is backwards compatible?

@cmizzi
Copy link
Contributor Author

cmizzi commented Jan 26, 2018

I didn't see any update for that on 5.5 (and earlier). I don't have environment to test it for >=5.5 but the code doesn't seems to be changed from 5.4 to earlier. The Illuminate\Session\Store seems to be used again, and it kept his interface to Illuminate\Contracts\Session\Session

@andig andig merged commit 0a3801d into php-pm:master Jan 26, 2018
@andig andig added this to the 1.1 milestone Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants