Generate mysqli methodsynopses based on stubs #301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Jan 1, 2021
| @@ -52,7 +50,7 @@ | |||
| <variablelist> | |||
| &mysqli.stmt.description; | |||
| <varlistentry> | |||
| <term><parameter>var</parameter></term> | |||
| <term><parameter>vars</parameter></term> | |||
There was a problem hiding this comment.
Same as with bind_param. The first variable is mandatory, the rest is optional.
kocsismate
force-pushed
the
mysqli-stubs
branch
from
3b03861 to
d4c49ca
Compare
kocsismate
force-pushed
the
mysqli-stubs
branch
from
d4c49ca to
2ba2dd1
Compare
|
@kamil-tekiela I've just rebased to master, and adapted a few recent changes. Can you please take another look on this PR? |
kamil-tekiela
requested changes
Feb 18, 2021
|
@kamil-tekiela I've just added the suggested change! |
php-pulls
pushed a commit
that referenced
this pull request
Mar 18, 2021
|
Thanks to all of you! I have committed most of the changes as 7e5d0d1, but was not sure about the rest. Rebased onto master. |
|
Besides a need to rebase, what else is preventing this PR from being merged? |
|
I'm closing this PR in favor of a few followups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.