-
Notifications
You must be signed in to change notification settings - Fork 800
Sync some methodsynopses with stubs #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
69e424a
to
d2d3701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly right, thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, LGTM. Thanks.
@@ -10,7 +10,7 @@ | |||
&reftitle.description; | |||
<methodsynopsis> | |||
<type>bool</type><methodname>ob_start</methodname> | |||
<methodparam choice="opt"><type>callable</type><parameter>callback</parameter><initializer>&null;</initializer></methodparam> | |||
<methodparam choice="opt"><type class="union"><type>callable</type><type>null</type></type><parameter>callback</parameter><initializer>&null;</initializer></methodparam> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welp... time to add to my list to refactor this function to use the ZPP callable check...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice :)
d2d3701
to
ddba7d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, LGTM otherwise
Co-authored-by: Gina Peter Banyard <[email protected]>
I intended to fix some of the methodsynopses which didn't need a changelog.