Skip to content

[PHP 8.4] Add errors for GetText functions #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

saundefined
Copy link
Member

No description provided.

@saundefined saundefined added this to the PHP 8.4 milestone Oct 29, 2024
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag should be amended

Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Christoph M. Becker <[email protected]>
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is good to go, I think. @Girgias?

@Girgias
Copy link
Member

Girgias commented Nov 3, 2024

Yes, except if we want to wait for the PR that uses PI to land and use those instead?

@Girgias Girgias merged commit a4fd6e6 into php:master Nov 13, 2024
2 checks passed
@saundefined saundefined deleted the php84-gettext-errors branch November 14, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants