PHP 8.4: pgsql: Add pg_set_chunked_rows_size, PGSQL_TUPLES_CHUNK
#4117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Nov 21, 2024
| <refsect1 role="returnvalues"> | ||
| &reftitle.returnvalues; | ||
| <simpara> | ||
| Returns &true; on success or &false; on failure. |
There was a problem hiding this comment.
I'm pretty sure for this you can use &return.success; (or something similar to this)
There was a problem hiding this comment.
Thanks for letting me know. I'm happy that this will make localization easier!
b68685e
Comment on lines
29
to
31
| <listitem> | ||
| &pgsql.parameter.connection-with-unspecified-default; | ||
| </listitem> |
There was a problem hiding this comment.
Can the connection parameter be unspecified? If not this is the wrong entity to use (there should be a similar one tho)
There was a problem hiding this comment.
Thanks, the parameter is required. I fixed the referencing entity.
5d0ac3e
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Girgias
reviewed
Nov 21, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
I'm not very good at English, so please feel free to point out or correct any unnatural parts in my phrasing.