Updated pdo_odbc, odbc_connect and odbc_pconnect #4215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
odbc_connections
branch
from
eb0c380 to
18d9621
Compare
SakiTakamachi
changed the title
SakiTakamachi
force-pushed
the
odbc_connections
branch
from
18d9621 to
c7e3125
Compare
|
This is conflicting with #4186, please wait for that PR to be merged first, rebase, and I'll have a look after. |
|
This looks good with a quick read, but yeah, let's wait to rebase. |
SakiTakamachi
force-pushed
the
odbc_connections
branch
from
c7e3125 to
70d4125
Compare
|
rebase done |
SakiTakamachi
force-pushed
the
odbc_connections
branch
from
70d4125 to
fb8def5
Compare
NattyNarwhal
approved these changes
Dec 3, 2024
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Co-authored-by: Gina Peter Banyard <[email protected]>
Girgias
reviewed
Dec 6, 2024
|
This also needs updating in the migration guide as this was not in UPGRADING. |
|
For now, is it okay to merge this? I will create a follow-up PR for the points pointed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related changes php/php-src@bbe1222