Skip to content

Commit 099334d

Browse files
committed
Revert + add test for empty string in PDO::qutoe()
1 parent b124c0a commit 099334d

File tree

2 files changed

+22
-5
lines changed

2 files changed

+22
-5
lines changed

ext/pdo/pdo_dbh.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1147,11 +1147,6 @@ PHP_METHOD(PDO, quote)
11471147

11481148
PDO_CONSTRUCT_CHECK;
11491149

1150-
if (str_len == 0) {
1151-
zend_argument_value_error(1, "cannot be empty");
1152-
RETURN_THROWS();
1153-
}
1154-
11551150
PDO_DBH_CLEAR_ERR();
11561151
if (!dbh->methods->quoter) {
11571152
pdo_raise_impl_error(dbh, NULL, "IM001", "driver does not support quoting");
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
--TEST--
2+
PDO::quote() must accept empty string
3+
--SKIPIF--
4+
<?php
5+
if (!extension_loaded('pdo')) die('skip');
6+
$dir = getenv('REDIR_TEST_DIR');
7+
if (false == $dir) die('skip no driver');
8+
require_once $dir . 'pdo_test.inc';
9+
PDOTest::skip();
10+
?>
11+
--FILE--
12+
<?php
13+
if (getenv('REDIR_TEST_DIR') === false) putenv('REDIR_TEST_DIR='.__DIR__ . '/../../pdo/tests/');
14+
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
15+
16+
$pdo = PDOTest::factory();
17+
18+
var_dump($pdo->quote(''));
19+
20+
?>
21+
--EXPECT--
22+
string(2) "''"

0 commit comments

Comments
 (0)