Skip to content

Commit 66e293f

Browse files
committed
fixup! Migrate SOAP SDL resource to object
1 parent b273742 commit 66e293f

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

UPGRADING

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,8 @@ PHP 8.4 UPGRADE NOTES
140140
Checks using is_resource() (i.e. is_resource($soapClient->httpurl)) should
141141
be replaced with checks for null (i.e. $soapClient->httpurl !== null).
142142
. SoapClient::$sdl is now a Soap\Sdl object rather than a resource.
143-
Value checks using is_resource() should be replaced with checks for `null`.
143+
Checks using is_resource() (i.e. is_resource($soapClient->sdl)) should be
144+
replaced with checks for null (i.e. $soapClient->sdl !== null).
144145

145146
- SPL:
146147
. Out of bounds accesses in SplFixedArray now throw an exception of type

ext/soap/php_soap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ static inline soap_url_object *soap_url_object_fetch(zend_object *obj)
265265

266266
#define Z_SOAP_URL_P(zv) soap_url_object_fetch(Z_OBJ_P(zv))
267267

268-
typedef struct {
268+
typedef struct soap_sdl_object {
269269
sdl *sdl;
270270
zend_object std;
271271
} soap_sdl_object;

0 commit comments

Comments
 (0)