Skip to content

Commit 8fc5dae

Browse files
authored
Use sapi/cli/php to run tests for faster failure (#6931)
We always run test steps on azure, even if a previous step failed, because we don't want a failure in one configuration to prevent testing of other configurations. However, if building PHP fails in the first place, then we currently end up testing the system PHP binary. This is not only useless, but will also result in a test runner hang and cause the job to time out. Avoid this by using sapi/cli/php instead of the installed php as the test binary. If we fail to build, then it will not exist, and testing will fail immediately.
1 parent b904085 commit 8fc5dae

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

azure/macos/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ steps:
99
export SKIP_IO_CAPTURE_TESTS=1
1010
export CI_NO_IPV6=1
1111
rm -rf junit.xml | true
12-
/usr/local/bin/php run-tests.php -P -q \
12+
sapi/cli/php run-tests.php -P -q \
1313
-j$(sysctl -n hw.ncpu) \
1414
-g FAIL,XFAIL,BORK,WARN,LEAK,XLEAK,SKIP \
1515
--offline \

azure/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ steps:
1717
export SKIP_IO_CAPTURE_TESTS=1
1818
export MSAN_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer
1919
rm -rf junit.xml | true
20-
php run-tests.php -P -q \
20+
sapi/cli/php run-tests.php -P -q \
2121
-j$(/usr/bin/nproc) \
2222
-g FAIL,XFAIL,BORK,WARN,LEAK,XLEAK,SKIP \
2323
--offline \

0 commit comments

Comments
 (0)