Skip to content

Commit f1702d2

Browse files
committed
Suppress MSVC C4995 warnings (deprecations)
These have the same meaning as C4996[1] (which we already suppress), but are triggered by a different mechanism[2]. It makes no sense to suppress one, but not both. Of course it would be better not to suppress either, but wrt the two C4995 warnings we see in php-src, that requires deprecation of using the ODBC cursor library[3], so might take a while. [1] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996> [2] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4995> [3] <https://externals.io/message/126264> Closes GH-17664.
1 parent 236e12e commit f1702d2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

win32/build/confutils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3269,9 +3269,9 @@ function toolset_setup_common_cflags()
32693269
// disable annoying warnings. In addition, time_t defaults
32703270
// to 64-bit. Ask for 32-bit.
32713271
if (TARGET_ARCH == 'x86') {
3272-
ADD_FLAG('CFLAGS', ' /wd4996 /D_USE_32BIT_TIME_T=1 ');
3272+
ADD_FLAG('CFLAGS', ' /wd4995 /wd4996 /D_USE_32BIT_TIME_T=1 ');
32733273
} else {
3274-
ADD_FLAG('CFLAGS', ' /wd4996 ');
3274+
ADD_FLAG('CFLAGS', ' /wd4995 /wd4996 ');
32753275
}
32763276

32773277
if (PHP_DEBUG == "yes") {

0 commit comments

Comments
 (0)