Suppress MSVC C4995 warnings (deprecations) #17664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have the same meaning as C4996[1] (which we already suppress), but are triggered by a different mechanism[2]. It makes no sense to suppress one, but not both. Of course it would be better not to suppress either, but wrt the two C4995 warnings we see in php-src, that requires deprecation of using the ODBC cursor library[3], so might take a while. [1] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996> [2] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4995> [3] <https://externals.io/message/126264>
|
The CircleCI failure is unrelated, but should probably investigated. The behavior of that ICU 70.1-2 is like that of ICU 76.1; are they using non-standard data there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have the same meaning as C4996[1] (which we already suppress), but are triggered by a different mechanism[2]. It makes no sense to suppress one, but not both.
Of course it would be better not to suppress either, but wrt the two C4995 warnings we see in php-src, that requires deprecation of using the ODBC cursor library[3], so might take a while.
[1] https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4996
[2] https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4995
[3] https://externals.io/message/126264