Test is flaky sapi/cli/tests/php_cli_server_pdeathsig.phpt

[andypost]

Description

The following test fails randomly on x86_64 and ppc64le builders (did not check on arm)

Resulted in this output:

TEST 16215/16381 [sapi/cli/tests/php_cli_server_pdeathsig.phpt]
========DIFF========
- Done
+ Fatal error: Uncaught Exception: Workers were not properly terminated. Before: 16615, 16616, after: 16615, 16616 in /home/buildozer/aports/testing/php83/src/php-8.3.0alpha1/sapi/cli/tests/php_cli_server_pdeathsig.php:34
+ Stack trace:
+ #0 {main}
+   thrown in /home/buildozer/aports/testing/php83/src/php-8.3.0alpha1/sapi/cli/tests/php_cli_server_pdeathsig.php on line 34
========DONE========
FAIL Killing server should terminate all worker processes [sapi/cli/tests/php_cli_server_pdeathsig.phpt] 

But few runs in docker does not allow to reproduce it locally

PHP Version

PHP 8.3.0-alpha1

Operating System

Alpinelinux

[iluuu1994]

@andypost Does increasing the max tries in the test fix it? It running for 0.5s max atm, increasing that to something like 2s shouldn't be an issue if it helps.

[andypost]

Thanks, good idea to give a try, maybe tag this test somehow as PERFORMANCE to be able to skip?

[iluuu1994]

@andypost SKIP_PERF_SENSITIVE would be ok too, if increasing the number of retries doesn't help.

[andypost]

@iluuu1994 following patch allowed to be sure it pass

diff --git a/sapi/cli/tests/php_cli_server_pdeathsig.phpt b/sapi/cli/tests/php_cli_server_pdeathsig.phpt
index 9bec95d3f2..db4b99af61 100644
--- a/sapi/cli/tests/php_cli_server_pdeathsig.phpt
+++ b/sapi/cli/tests/php_cli_server_pdeathsig.phpt
@@ -38,7 +38,7 @@ function find_workers_by_pids(array $pids) {
 proc_terminate($cliServerInfo->processHandle, 9); // SIGKILL
 
 $try = 1;
-$max_tries = 5;
+$max_tries = 20;
 while (true) {
     $workersAfter = find_workers_by_pids($workersBefore);
     if (count($workersAfter) === 0) {

[andypost]

Ref alpinelinux/aports@63e708e