JSON_ERROR_DEPTH with JSON_PARTIAL_OUTPUT_ON_ERROR.

[vituko]

Description

Hi, json_encode, when it exceeds the max depth, having the flag JSON_PARTIAL_OUTPUT_ON_ERROR, just ignores the max depth and goes on. Shouldn't be a better choice to stop at that depth, replacing by null, for example, following the "partial output" sense as with JSON_ERROR_RECURSION?
Ignoring the optional depth limit seems a bug and truncating the chain of references with null, giving a partial output seems natural.
It seems a trivial change in the sources, thank you.

[vituko]

I mean [1,[2,[3]]], for a max depth of 2: [1,[2,null]]

[SakiTakamachi]

@vituko
Hello! Such feature additions are generally discussed on the php internal mailing list rather than in GitHub issue threads. So if you're interested in that, I encourage you to post to the mailing list.

[bukka]

I have been thinking about this and it seems actually more logical then completely ignoring depth. I think this is actually oversight and it wasn't meant to be working in this way. We also did not mention it in docs.

@vituko We need for sure at least some discussion on internals about and possibly RFC if there is no consensus. Are you happy to do that or do you want me to start discussion?