Error messages for ldap_mod_replace are confusing

[stof]

Description

When validating the $entry argument of ldap_mod_replace, the validation runs on each element of the array of the entry, but the error message looks like it applies on the whole entry:

[ValueError]                                                            
  ldap_modify(): Argument #3 ($entry) must be an array with numeric keys

This is quite confusing given that $entry explicitly expects an associative array. The error message should mention that this is an error related to the value of one attribute of the entry (and ideally should mention the name of the invalid attribute):

php-src/ext/ldap/ldap.c

Line 2277 in 2862302

ZEND_HASH_FOREACH_STR_KEY_VAL(attributes_ht, attribute, attribute_values) {

PHP Version

PHP 8.4.4

Operating System

No response

[nielsdos]

I think this makes sense, and I think it's fine to fix this in 8.4.
Similarly the message a few lines up of "list of attribute values must not be empty" can be improved as well, maybe other functions too.

[ralfbecker]

I'm using PHP 8.3.17 and getting the error-message from the following call:

ldap_mod_replace($ds, ‘uid=atesti,ou=People,dc=example,dc=org’, {“mail”:[“atesti@example.org”],“objectclass”:[“top”,“person”,“organizationalPerson”,“inetOrgPerson”,“posixAccount”,“shadowAccount”]})

ldap_mod_replace(): Argument #3 ($entry) must be an array with numeric keys (0);

(The parameters are json-encoded in the debug-output, not the actual call!)

So it looks like there is not only a problem with the wording of the error-message, but also with the validation itself.

Ralf

[nielsdos]

@ralfbecker That should be fixed in PHP 8.3.19.

[ralfbecker]

Thx :)

Just wanted to make sure it's already reported / taken care of.

Ralf