Throw error when mysql_stmt_data_seek fails #10419
Conversation
| @@ -1513,7 +1513,10 @@ PHP_FUNCTION(mysqli_stmt_data_seek) | |||
|
|
|||
| MYSQLI_FETCH_RESOURCE_STMT(stmt, mysql_stmt, MYSQLI_STATUS_VALID); | |||
|
|
|||
| mysql_stmt_data_seek(stmt->stmt, offset); | |||
| if (mysql_stmt_data_seek(stmt->stmt, offset)) { | |||
| zend_throw_error(NULL, "The result set buffer is empty"); | |||
There was a problem hiding this comment.
Not sure about the wording; is there even a buffer in this case. Maybe "Result set is not buffered" (or something like that) gives a better clue about what's wrong.
There was a problem hiding this comment.
Yes, currently nothing happens. This is because until now we supported libmysql, which as stated above has this function implemented as void. Now, we are no longer limited by libmysql and we can start throwing an error.
I could also change this to a warning, but I don't see this happening very often and I don't it would be too much to have an error here.
In regards to the text, I wanted to find something rather vague. The error could happen because someone forgot to call store_result(), the PS has only been prepared but not yet executed, or the PS didn't produce any result set. Your suggestion fits the first reason, but not so much the rest. I welcome some brainstorming here.
|
I think it's too late for 8.3 as we are well past feature freeze and this is behaviour changes that should at least be emailed to internals. I think it makes sense to do it but might be better to target 8.4 |
According to the MySQL standard
mysql_stmt_data_seekshould be a void function, but in mysqlnd it was always returningbool. In this case, it makes sense to check for an error condition and inform the mysqli user about incorrect usage.The only time this function returns false is if it's used on PS without a buffered result set, hence the text of the error message.