Add zend_alloc XLEAK support #10999
Closed
Add zend_alloc XLEAK support #10999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future we may want to use a different exit code to warn for tests that didn't leak.
iluuu1994
force-pushed
the
zend_alloc-xleak
branch
from
b93d971 to
e6df4f4
Compare
iluuu1994
commented
Apr 3, 2023
| @@ -4,7 +4,7 @@ Bug #53251 (bindtextdomain with null dir doesn't return old value) | |||
| gettext | |||
| --SKIPIF-- | |||
| <?php | |||
| if (getenv('SKIP_REPEAT')) die('skip gettext leaks global state across requests'); | |||
| if (getenv('SKIP_REPEAT')) die('xleak gettext leaks global state across requests'); | |||
There was a problem hiding this comment.
The leaking here doesn't refer to memory, so this should be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future we may want to use a different exit code to warn for tests that didn't leak.