Fix test bug60120.phpt #11064
Closed
Fix test bug60120.phpt #11064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
force-pushed
the
fix-bug60120.phpt
branch
from
abaed39 to
11eb9fb
Compare
dstogov
approved these changes
Apr 12, 2023
| @@ -16,7 +16,7 @@ $php = getenv('TEST_PHP_EXECUTABLE'); | |||
| if (!$php) { | |||
| die("No php executable defined\n"); | |||
| } | |||
| $cmd = 'php -r "fwrite(STDOUT, $in = file_get_contents(\'php://stdin\')); fwrite(STDERR, $in);"'; | |||
| $cmd = 'php -r "\$in = file_get_contents(\'php://stdin\'); fwrite(STDOUT, \$in); fwrite(STDERR, \$in);"'; | |||
There was a problem hiding this comment.
I wonder, how this worked before... :(
Also 'php... should be replaced by $php . '...
There was a problem hiding this comment.
I wonder, how this worked before... :(
Doesn't look like it ever did, there were just no checks.
Also 'php... should be replaced by $php . '...
Right, I missed this!
The process cmd was broken. We're now also checking that the process output is actually what we expect.
iluuu1994
force-pushed
the
fix-bug60120.phpt
branch
from
11eb9fb to
049f286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process cmd was broken. We're now also checking that the process output is actually what we expect.
/cc @dstogov