ext/pgsql: pg_cancel_query internal update. #11081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Apr 29, 2023
ext/pgsql/pgsql.c
Outdated
|
|
||
| if (!c) { | ||
| // only possible reason since the connection is already verified at that point | ||
| zend_error(E_WARNING, "can't allocate a cancel procedure"); |
There was a problem hiding this comment.
Doesn't pgsql use ZMM? in which case the engine will bailout before.
If not, well that's something that is suboptimal but requires pgsql to allow setting a custom allocator.
PS: still on holiday for a week but going through the wooping amount of emails I got
devnexen
force-pushed
the
pgsql_cancel_query_update
branch
from
40383d3 to
c30a220
Compare
Girgias
approved these changes
May 5, 2023
ext/pgsql/pgsql.c
Outdated
| c = PQgetCancel(pgsql); | ||
| RETVAL_LONG((rc = PQcancel(c, err, sizeof(err)))); | ||
| if (rc < 0) { | ||
| zend_error(E_WARNING, "can't cancel the query: %s", err); |
There was a problem hiding this comment.
Nit: I think this is our usually spelling
Suggested change
| zend_error(E_WARNING, "can't cancel the query: %s", err); | |
| zend_error(E_WARNING, "cannot cancel the query: %s", err); |
Removing (obsolete) PGrequestCancel usage in favor of the thread-safe PQcancel/PQfreeCancel pair.
devnexen
force-pushed
the
pgsql_cancel_query_update
branch
from
c30a220 to
b022108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing (obsolete) PGrequestCancel usage in favor of the thread-safe
PQcancel/PQfreeCancel pair.