When running FPM tests, pass -n option to php-fpm #11373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"make test" was failing for me, because I was running it prior to install, and there was an old installed version which was incompatible. The FPM tests were using the installed php.ini which referenced installed dynamically linked extensions. So, pass -n to php-fpm. FPM\Tester::start() has $extensions, $iniEntries and TEST_FPM_EXTENSION_DIR but they are not actually set by anything. Rather than rely on the installed php.ini to be correct, it seems safer to pass -n, and any tests that need specific config can pass $iniEntries.
bukka
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
It's been useful in past to change ini and extension but both are now supported using test params so I agree there is no longer need for this and it also made some failures for other users in past. I just tested it locally and it also passes for all other tests that are not running in the pipeline so all good.
|
Just a note that I will merge it to master only in case some configurations depended for some reason on their ini even though it is probably unlikely but don't want to be bothered about stable version complications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"make test" was failing for me, because I was running it prior to
install, and there was an old installed version which was incompatible.
The FPM tests were using the installed php.ini which referenced
installed dynamically linked extensions.
So, pass -n to php-fpm.
FPM\Tester::start() has $extensions, $iniEntries and
TEST_FPM_EXTENSION_DIR but they are not actually set by anything. Rather
than rely on the installed php.ini to be correct, it seems safer to pass
-n, and any tests that need specific config can pass $iniEntries.