Skip to content

ext/gd: imagerotate removes ignore_transparent argument. #11426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

seems to be a relic of PHP 5 but no longer makes sense in regard of gdImageRotateInterpolated.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but this will need a BC break entry in UPGRADING.

Do specify that this was ignored since a long time.

seems to be a relic of PHP 5 but no longer makes sense in regard of gdImageRotateInterpolated.
@devnexen devnexen force-pushed the gd_imagerotate_update branch from e6e8cb7 to 9cb37d7 Compare June 13, 2023 17:21
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants