Fix GH-11550: MySQL Statement has a empty query result when the response field has changed, also Segmentation fault

[Yurunsoft]

fix #11550

Segmentation fault also occurs in PHP 8.0, should it be merged into the PHP-8.0 branch?

[kamil-tekiela]

I can't review it properly right now, but a few points: - don't add unnecessary parentheses after require statement - when you include "connect.inc", use the helper functions from it instead of instantiating new mysqli - don't change unrelated files. If you want to fix the debug comments, do it in separate pr revised against master

…

On Wed, Jun 28, 2023, 16:07 George Peter Banyard ***@***.***> wrote: @Girgias <https://github.com/Girgias> requested your review on: #11551 <#11551> Fix GH-11550 <#11550>: MySQL Statement has a empty query result when the response field has changed, also Segmentation fault. — Reply to this email directly, view it on GitHub <#11551 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSHGGCNYM3LODYXJKEZXNTXNQ3DDANCNFSM6AAAAAAZWWASZY> . You are receiving this because your review was requested.Message ID: ***@***.***>

[carleii]

I totally approve that.

[Yurunsoft]

I can't review it properly right now, but a few points: - don't add unnecessary parentheses after require statement - when you include "connect.inc", use the helper functions from it instead of instantiating new mysqli - don't change unrelated files. If you want to fix the debug comments, do it in separate pr revised against master
…
On Wed, Jun 28, 2023, 16:07 George Peter Banyard @.> wrote: @Girgias https://github.com/Girgias requested your review on: #11551 <#11551> Fix GH-11550 <#11550>: MySQL Statement has a empty query result when the response field has changed, also Segmentation fault. — Reply to this email directly, view it on GitHub <#11551 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSHGGCNYM3LODYXJKEZXNTXNQ3DDANCNFSM6AAAAAAZWWASZY . You are receiving this because your review was requested.Message ID: @.>

I have modified the code, except for mysqli.
I see other test cases that also instantiate mysqli.

[Yurunsoft]

@kamil-tekiela Could you review this PR?

This problem is fatal in memory-resident applications (e.g. Workerman, Swoole, etc.)