add SKIP_SLOW_TEST's + slow locator script #11647
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made a script to look for tests everywhere, and run them all 3 times with SKIP_SLOW_TESTS set, and rank them all by best-of-3-runs, and found a couple of slow-ish tests and added SKIP_SLOW_TEST to them.
oh, and the run-tests.php thing is just a performance optimization really, in PHP (and some other languages) ++i is faster than i++ , also i++ is a strange operator, here is what i++ means:
by comparison, here is what ++i means:
even in GCC you'll see ++i being faster than i++ on -O0 (disable optimizations), but gcc auto-optimize i++ to ++i on O1 and above ~ (at least this was true back in the gcc 4.x days. Remember a story, maybe back in 2006, where we significantly increased the performance of a large binary data format parser on
gcc -g
(debug) by simply replacing i++ with ++i.. back in those days, gcc's-Og
(optimize-and-debug) profile did not exist. )