Skip to content

Implement DOMParentNode::replaceChildren() #11699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

nielsdos
Copy link
Member

ref: https://dom.spec.whatwg.org/#dom-parentnode-replacechildren

This is based on the fix in #11698, but I will rebase once that PR is merged.

@nielsdos nielsdos marked this pull request as draft July 13, 2023 14:22
@nielsdos
Copy link
Member Author

Hmmm, crashes in CI but not locally, I'll investigate.

@Girgias Girgias self-requested a review July 13, 2023 14:25
@nielsdos nielsdos force-pushed the dom-parentNode-replaceChildren branch from ec84545 to e7212d5 Compare July 13, 2023 17:10
@nielsdos
Copy link
Member Author

nielsdos commented Jul 13, 2023

I think I fixed it... I initialized the argument count for the variadic arguments to zero. Apparently the "*" specifier doesn't fill in the zval* or uint32_t argument count when it is the only specifier?? That feels like a bug on its own to me, or at least a footgun.
Let's see what CI says first though

@nielsdos nielsdos marked this pull request as ready for review July 13, 2023 18:16
@Girgias
Copy link
Member

Girgias commented Jul 14, 2023

I think I fixed it... I initialized the argument count for the variadic arguments to zero. Apparently the "*" specifier doesn't fill in the zval* or uint32_t argument count when it is the only specifier?? That feels like a bug on its own to me, or at least a footgun. Let's see what CI says first though

That does seem... odd

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsdos nielsdos merged commit e8f0bdc into php:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants