ext/calendar: Allow easter_date to process years after 2037 on 64bit systems #11862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arne1303
changed the title
Arne1303
changed the title
Arne1303
force-pushed
the
easter_date_64_bit
branch
2 times, most recently
from
4a15b78 to
f2828e1
Compare
Arne1303
commented
Aug 3, 2023
Girgias
requested changes
Aug 3, 2023
Arne1303
force-pushed
the
easter_date_64_bit
branch
from
f2828e1 to
456301e
Compare
Girgias
approved these changes
Aug 3, 2023
Added a check to easter_date to allow it to run with years past 2037 when on a 64bit platform.
Arne1303
force-pushed
the
easter_date_64_bit
branch
from
456301e to
c5a4c31
Compare
|
@Girgias I fixed the cs and added an entry to UPGRADING! Is there a tool which shows cs violations in this project, or is it more a learning thing to get it right? |
|
I also submitted PR's to update the English and German docs: doc_en: php/doc-en#2643 |
This was referenced Aug 4, 2023
No we don't have any such tools, I think some people have tried but it was too difficult to setup :/ |
Girgias
approved these changes
Aug 4, 2023
Comment on lines
+306
to
+309
| - Calendar | ||
| . easter_date() now supports years from 1970 to 2,000,000,000 on 64-bit systems, | ||
| previously it only supported years in the range from 1970 to 2037. | ||
|
|
There was a problem hiding this comment.
We list these in alphabetical order, but that can be fixed as a follow-up for now
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
…1862) Added a check to easter_date to allow it to run with years past 2037 when on a 64bit platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, easter_date always threw an error if executed with a year after 2037. This was done to prevent an integer overflow with Unix timestamps in the years after 2038 from appearing. (Y2K38 bug)
Since the overflow does not happen with signed 64-bit integers, I added a check to allow easter_date to run on 64bit systems with years after 2037.