Make the $enable parameter of odbc_autocommit() nullable #11909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Aug 8, 2023
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (!(conn = (odbc_connection *)zend_fetch_resource2(Z_RES_P(pv_conn), "ODBC-Link", le_conn, le_pconn))) { | ||
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| if (ZEND_NUM_ARGS() > 1) { | ||
| if (!pv_onoff_is_null) { |
There was a problem hiding this comment.
Minor nit, but can you change the RETVAL_TRUE to RETURN_TRUE
|
Windows failure is legit, seems like the default value is different |
Girgias
reviewed
Aug 8, 2023
Co-authored-by: George Peter Banyard <[email protected]>
Co-authored-by: George Peter Banyard <[email protected]>
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
Co-authored-by: George Peter Banyard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.