Add more test coverage for ext/ODBC #11938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kocsismate
commented
Aug 11, 2023
kocsismate
commented
- adds tests for many functions which used to be untested
- enable tests on Linux with unixODBC
- fix (mostly xfail or skip) failing tests
github-actions
bot
added
Extension: odbc
Extension: pdo (core)
Extension: pdo_odbc
labels
12 tasks
Girgias
reviewed
Aug 11, 2023
There was a problem hiding this comment.
Nice!
Main comments are about reducing the number of insertions queries and being confused at the inconsistent handling of the row parameter.
I also wonder if it makes sense to (in a follow-up) PR to enhance the warnings about invalid row numbers (if too larg) to use the appropriate function to check if the row number queried is actually in range? This could allow us to convert that case to a ValueError in the future.
|
Additionally, I managed to get rid of the |
Girgias
reviewed
Aug 22, 2023
Comment on lines
+28
to
+24
| var_dump(odbc_fetch_into($res, $arr, 0)); | ||
| var_dump($arr); |
|
|
||
| Warning: odbc_field_len(): Field index larger than number of fields in %s on line %d |
There was a problem hiding this comment.
One should know the database schema one is dealing with tho?
Also odbc_num_fields() exists, but that's an aside.
kocsismate
force-pushed
the
odbc-tests
branch
3 times, most recently
from
ef03a2d to
58e86d1
Compare
Girgias
approved these changes
Aug 23, 2023
ext/odbc/tests/bug69354.phpt
Outdated
| --EXPECT-- | ||
| 100 | ||
| a | ||
| a |
Some test failures are fixed, parallelization is enabled, section order is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.