DNF types bug fixes and others #11961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2023
Trait bug Internal class property bug
Girgias
force-pushed
the
internal-list-types
branch
from
bfd227d to
2094880
Compare
|
You might also add validation logic to |
Good point, but the PR for 8.2 I'm writing won't have the validation logic, and typed constants is only a thing since 8.3 |
|
Most of this PR was merged as 02a80c5 when fixing all the other DNF bugs. The only useful thing from here would be the zend_type validation code for debug builds, but not sure how worthwhile this is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft and a bit of a mishmash of solving bugs and adding tests for issues I discovered while working on #11884
I've added a function to verify that a
zend_typeis actually well-defined, which seems to be the true underlying issue of #11884 as for some reason something is happening during the variance checks that messes up the "inner" intersection type list allocation variant (so going from arena to something else) when the outside union type list is still as expected arena allocated.I can't find any "obvious" issues with the persistence size calculation, nor the actual persistence operation in opcache.